Support boot CPU not being 0. #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dberlin
force-pushed
the
m3-work-boot-not-zero
branch
5 times, most recently
from
7d20b94 to
708ba9e
Compare
Right now, we assume the boot cpu is cpu0. That is not true on m3 max, where it is CPU 4. To figure out which CPU is the boot CPU, we check to see which CPU is running before we start any other CPUs, and record the MPIDR/idx. Without this patch, four issues happen on m3 max: 1. We try to start the boot CPU again, crashing it 2. We skip the real CPU 0 3. We start m1n1 again on CPU0 when we boot it 4. We enable interrupts on CPU0 because we think it's the primary CPU. Signed-off-by: Daniel Berlin <[email protected]>
dberlin
force-pushed
the
m3-work-boot-not-zero
branch
from
708ba9e to
69b2d36
Compare
|
This is probably going to break a pile of scripts on the python side too, but we'll deal with that later :) |
|
I have the fixes for hv/* on the python side coming up, since i had to add
proxy support to retrieve the boot cpu info.
It's good enough to at least crash macos on the first msr ;)
…On Sun, Dec 3, 2023 at 3:23 AM Hector Martin ***@***.***> wrote:
This is probably going to break a pile of scripts on the python side too,
but we'll deal with that later :)
—
Reply to this email directly, view it on GitHub
<#368 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACPI25UAW7OMCBTA3LLJBLYHQZHFAVCNFSM6AAAAABACDH3OKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGQYDMOBYGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we assume the boot cpu is cpu0. That is not true on m3 max,
where it is cpu4.
To figure out which CPU is the boot CPU, we check to see which CPU
is running before we start any other CPUs, and record the MPIDR/idx.
Without this patch, four issues happen on m3 max:
Signed-off-by: Daniel Berlin [email protected]